Problem/Motivation

INSTALL.txt needs to be updated for new requirements. There are minimum version constants in database classes that need to be updated too.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3568123

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14383

quietone’s picture

quietone commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I left a comment on the MR for a line in INSTALL.txt that was missed. I'm setting the status to Needs Work for that.

Would you like to expand the scope to clean up this remaining bit of IIS-related text on lines 79-80?

For Clean URLs support on IIS, see "Clean URLs with IIS"
(https://www.drupal.org/node/3854) in the Drupal.org online documentation.

core/modules/mysql/src/Driver/Database/mysql/Install/Tasks.php has a MariaDB version constant with the old version, similar to the one that's being updated for PostgreSQL. The MySQL constant in the same file is correct.

quietone’s picture

quietone commented
Status: Needs work » Needs review
Related issues: +#3086655: Add composer instructions to INSTALL.txt

@dcam, thanks. I have made the changes you suggested.

Adding a related issue about updates to INSTALL.txt.

nicxvan’s picture

nicxvan commented

Is SQLITE_MINIMUM_VERSION still 3.45?

dcam’s picture

dcam commented

Is SQLITE_MINIMUM_VERSION still 3.45?

Yes, according to the blog post.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Thank you for considering my feedback. These changes look good to me.

dcam’s picture

dcam commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

We need to update the jobs in gitlab to not use postgres 16 (I think we should update the commit job and remove the daily job). We also need to update the maria jobs to use a permitted version - 10.11 i guess.

dcam’s picture

dcam commented

There's also a merge conflict in core/INSTALL.txt since we removed the mention of Percona.

quietone’s picture

quietone commented
Status: Needs work » Needs review

The work asked for in #10 is in issue #3569115: Add core testing with MariaDb 10.11

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Merge conflict appears addressed. Seems this was previously RTBC and #12 mentions gitlab update is another ticket.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This is going to break on commit because the tests will try to run on Postgres 16 and MariaDB 10.6.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Either this needs work or must be postponed on #3569115: Add core testing with MariaDb 10.11, I guess.

smustgrave’s picture

smustgrave commented

Will that issue break without this one? To determine if they should go in together

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs review

Rebased due to #3086655: Add composer instructions to INSTALL.txt

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good rebase.

Thanks for keeping up with all theses. Some overlap so much hard to keep track

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c69be14 and pushed to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed c69be144 on main 
    task: #3568123 Update INSTALL.txt for Drupal 12

By: quietone
By: dcam...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone closed merge request !14383