Problem/Motivation

See #3566536: [meta] eliminate core .module files

Proposed resolution

Convert to class methods the following procedural form submit, validation and Ajax callbacks:

  • editor_form_filter_admin_format_editor_configure()
  • editor_form_filter_admin_form_ajax()
  • editor_form_filter_admin_format_validate()
  • editor_form_filter_admin_format_submit()

Remaining tasks

None.

User interface changes

None.

Introduced terminology

None.

API changes

Deprecated procedural functions:

  • editor_form_filter_admin_format_editor_configure()
  • editor_form_filter_admin_form_ajax()
  • editor_form_filter_admin_format_validate()
  • editor_form_filter_admin_format_submit()

Data model changes

None.

Issue fork drupal-3568092

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Title: Convert procedural submit, validate and Ajax callbacks to methods » Convert editor.module procedural submit, validate and Ajax callbacks to methods

claudiu.cristea opened merge request !14381

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
Status: Active » Needs review

Ready for review

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
dcam’s picture

dcam commented
Status: Needs review » Needs work

There's a doc reference to editor_form_filter_admin_form_ajax() in core/modules/ckeditor5/ckeditor5.module line 50.

There's a comment reference to editor_form_filter_admin_format_submit() in core/modules/ckeditor5/src/Plugin/Editor/CKEditor5.php line 920.

I'm setting the status to Needs Work to change these two items in the MR.

The existing changes and change record look good to me.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Needs review

Ouch! Thanks for catching.

Fixed. Not that I've added for each a @see tag with the full FQN as in the comment it would had been too ugly to refer the FQN of the methods.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I did my best to put the functionality through its paces in order to verify it's still working. In particular I focused on the no-JS functionality since that seems to be what this is mostly about from what I can tell. Everything was still working properly. My feedback on the MR was addressed. This looks good to me.

nicxvan made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

This applies to main but not 11.x because of other changes since (probably other deprecations!).

I think we will need separate MRs for 11.x and main here - in which case in the main one we may as well remove the deprecated functions straight away.

claudiu.cristea opened merge request !14709

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Reviewed & tested by the community

@longwave

I've created 2 MRs:

nicxvan’s picture

nicxvan commented

Just confirmed the difference is removal vs deprecation, both look good!

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Straight reroll ^

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Another reroll ^

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks for bearing with us with all these rerolls recently.

Committed and pushed 3fb558de463 to main. Thanks!

Committed and pushed f237db4b684 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14709

  • longwave committed f237db4b on 11.x 
    refactor: #3568092 Convert editor.module procedural submit, validate and...

  • longwave committed 3fb558de on main 
    refactor: #3568092 Convert editor.module procedural submit, validate and...

longwave closed merge request !14381

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.