Problem/Motivation

Steps to reproduce

Trigger an error in the Klaro callback JS code, e.g. enable the Posthog service, but do not use posthog.

Result: A JS error occurs and the Klaro banner is NOT shown!

Proposed resolution

Catch any kind of errors inside the callback code, ensure the Klaro banner is shown and then re-trigger the errors for the console.

Ensure the general functionality can never be broken by defective callback scripts

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 klaro-3567998-MR119-6.patch701 byteslrwebks
#4 screenshot-2026-01-20 09_35_38.png27.24 KBgrevil
#4 screenshot-2026-01-20 09_30_56.png24.44 KBgrevil

Issue fork klaro-3567998

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil’s picture

grevil commented
Title: Errors in callback code shoult not kill the Klaro consent banner » Errors in callback code should not kill the Klaro consent banner

grevil opened merge request !119

grevil’s picture

grevil commented
Status: Active » Needs review
StatusFileSize
new screenshot-2026-01-20 09_30_56.png24.44 KB
new screenshot-2026-01-20 09_35_38.png27.24 KB

This should be it! Please review!

Before (Banner not showing):
screenshot

After (Banner showing):
screenshot2

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @grevil! That was exactly what I thought about.

We could theoretically even add a test to ensure the banner is not more broken, if the callback throws an error.

Let @Jan Kellermann decide...

lrwebks’s picture

lrwebks commented
StatusFileSize
new klaro-3567998-MR119-6.patch701 bytes

Static patch until this is merged

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Would be great if a maintainer could review this.

jan kellermann’s picture

jan kellermann commented
Status: Reviewed & tested by the community » Fixed

I merged your code for next klaro release. Thank you very much.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.