Problem/Motivation

In #3346394: Replace BlockContentController::add with EntityController::addPage via the AdminHtmlRouteProvider route provider the $requestStack was made a parameter just for the BC coverage. We can just use \Drupal

Steps to reproduce

Proposed resolution

Remove parameter

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3567980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !14370

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
dcam’s picture

dcam commented

Since this didn't go into 11.3 we're good as far as BC goes, right? And we'll just remove the change record, https://www.drupal.org/node/3546628?

smustgrave’s picture

smustgrave commented

So the CR is still valid for that function. we just don’t need to dependency inject the service for BC coverage.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Sorry. That's what I get for not reading carefully. I assumed the CR was for the addition to the EntityController constructor. I read through the comments on #3346394: Replace BlockContentController::add with EntityController::addPage via the AdminHtmlRouteProvider route provider. The BC and a CR was deemed unnecessary because Controllers aren't covered by BC. So this removal doesn't need one either. LGTM.

  • catch committed 66686fac on 11.x 
    task: #3567980 Remove unneeded parameter $requestStack from...

  • catch committed 69f701f3 on main 
    task: #3567980 Remove unneeded parameter $requestStack from...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14370

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Closed (fixed) » Patch (to be ported)

This needs backpirting to 11.3 i think. That is the only 11 version now with the constructor change. See https://drupal.slack.com/archives/C079NQPQUEN/p1779463657408219?thread_t...

bbrala’s picture

bbrala
Location Netherlands
commented
Related issues: +#3346394: Replace BlockContentController::add with EntityController::addPage via the AdminHtmlRouteProvider route provider

  • catch committed b615611f on 11.3.x 
    task: #3567980 Remove unneeded parameter $requestStack from...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Patch (to be ported) » Fixed

Cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

bbrala’s picture

bbrala
Location Netherlands
commented

ty!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.