\Drupal\path_alias\AliasPrefixList does lookups in a case-sensitive fashion but paths in Drupal are not case sensitive. This means the if node/1 is aliased to node_one when you do a lookup for NODE/1 with the path alias manager it will not find the alias but it will if you \Drupal\path_alias\AliasRepositoryInterface::lookupBySystemPath(),
Make AliasPrefixList case insenstive.
Make AliasRepository::preloadPathAlias() return an entry the path stored in the path alias table and a matching path (if they differ).
N/a
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !14344
Comments
Comment #3
alexpottComment #4
catchOnce comment on the MR, and could probably use test coverage, but otherwise makes sense.
Comment #5
alexpottAdded test coverage, addressed comment and made further changes to ensure the path alias manager is actually case insensitive.
Comment #6
alexpottComment #7
godotislateA couple test failures that look unrelated.
One question on the MR about the test assertion custom messages. I think the general suggestion from #3131946: [policy] Remove PHPUnit assertion messages when possible, and standardize remaining messages is not to use them, but not sure if that's final or if there are exceptions.
Comment #8
godotislateI rebased to get the validatable config job passing, and this LGTM after response about the assertion messages.
Comment #10
longwaveDoesn't apply following #3567086: Alias case sensitivity after the removal of the preload cache
Also instead of adding to the baseline should we just add return types here to the new methods? Or is there concern that AliasPrefixList has been extended somewhere and these methods are already overridden?
Comment #11
alexpottMerged in main - there we no conflicts to resolve.
I chose to add to the baseline after recent issues where we added typehints to things like this and broke projects and contributed modules. Just seems safer.
Comment #14
longwaveCommitted and pushed cd54e644bde to main and 66b5b396b0e to 11.x. Thanks!
Decided not to backport this one as it's a minor behaviour change, let's leave this for 11.4.0.