Problem/Motivation

This issue holds a bunch of minor fixes made while testing integration with my project.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gift_aid-3566807

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathanshaw created an issue. See original summary.

jonathanshaw opened merge request !24

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

OK, so this is mostly trivialities, but buried in the middle, over a series of 5 or so commits, is a big overhaul of the theming and self-declaration forms.

Basically I was premature in requesting #3560176: Unify and provide a UI for self-declaration wording/styling, I needed to do quite a lot of work to refine my understanding of the ideal text, before it became clearer how we could use templates etc to rationalise the theming and customisability of the text.

There's a pre-existing test fail, something to do with the D11.3 change to the entity controller addPage(). I've not got D11 installed locally so I've not tried to fix it on D11, but I have added a BC layer to make it work on D10.

adamps made their first commit to this issue’s fork.

adamps’s picture

adamps commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.