DynamicPropSource is strangely named. It gets data from entity fields, which means it is indeed "dynamic" in the sense that it's evaluated/fetched from there.
So "dynamic" is...technically true, but uninformative, and imposes extra cognitive load on anyone trying to understand Canvas's inner workings.
(Origin: "next-gen page builder" talk by @lauriii, see #3477428-16: [PP-1] Refactor (or decide not to) the XB field type to be multi-valued, to de-jsonify the tree, and to reference the field_union type of the prop values.)
So: rename to EntityFieldPropSource.
Site builders: update path
✅ Zero visible changes. No disruption. Just run the update path.
Module maintainers
✅ Zero visible changes. No disruption.
For Canvas developers: improved learning curve: As Code Clarity Chief, I am greatly pleased. I think this is such good clean-up. Making Canvas more grokable is a major win for us all!
— @phenaproxima
For recipe maintainers
It is recommended to re-save any exported/default Canvas content templates, and then re-export them. This will cause the exported data to refer to EntityFieldPropSource instead of DynamicPropSource.
It's not necessary: existing exports will continue to work for the remainder of Canvas 1.x. Canvas 2.x will drop the BC layer.
