Problem/Motivation

We can provide improved typehinting so we have a better idea that both a class string is returned, and the class string is a implementation of EntityInterface

Proposed resolution

Make the change.

Remaining tasks

User interface changes

None.

Introduced terminology

None.

API changes

Documentation only.

Data model changes

None.

Release notes snippet

None.

Issue fork drupal-3566616

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dpi created an issue. See original summary.

dpi opened merge request !14272

dpi’s picture

dpi
Location Perth, Australia
commented

Do/Gitlab is being incredibly flakey today, so heres a link: https://git.drupalcode.org/project/drupal/-/merge_requests/14272

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Category: Feature request » Task
Status: Needs review » Reviewed & tested by the community

Looks good to me, although are there any similar methods we could improve at the same time?

dpi’s picture

dpi
Location Perth, Australia
commented

Not in the same EntityStorageInterface.

Overall in Drupal there is of course plenty of ways to improve.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

  • catch committed e4f54139 on 11.x 
    docs: #3566616 Improve typehinting of \Drupal\Core\Entity\...

  • catch committed 7d43fc22 on main 
    docs: #3566616 Improve typehinting of \Drupal\Core\Entity\...

catch closed merge request !14272

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.