Problem/Motivation

Found when working on #2335523: Remove node.module.css from node/drupal.node library and deprecate node/form library and getting confused by the test failure output:

Theme "node" is overriding a deprecated library. The "node/form" asset library is deprecated in drupal:11.4.0 and is removed from drupal:12.0.0.

https://git.drupalcode.org/issue/drupal-2335523/-/jobs/7912016

In this example, Node is the extension that defines the original library, not the one that is overriding it.

This also applies to the libraries-extend deprecation message.

Steps to reproduce

See #2335523: Remove node.module.css from node/drupal.node library and deprecate node/form library

Proposed resolution

Fix the message to report the theme that is overriding the library

Remaining tasks

Do it

User interface changes

None

Introduced terminology

None

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3566514

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Title: Theme override deprecation message uses the wrong extension name » Theme override/extend deprecation message uses the wrong extension name

acbramley opened merge request !14266

acbramley’s picture

acbramley commented
Issue summary: View changes
acbramley’s picture

acbramley commented
Status: Active » Needs review

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

I've had this issue open for like a week and keep getting distracted.

I ran the test-only run https://git.drupalcode.org/issue/drupal-3566514/-/jobs/8573855 which shows coverage for the change. And change itself seems minimal.

LGTM

godotislate closed merge request !14266

  • godotislate committed e0fa1b64 on main 
    fix: #3566514 Theme override/extend deprecation message uses the wrong...

  • godotislate committed c9aa1d24 on 11.x 
    fix: #3566514 Theme override/extend deprecation message uses the wrong...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed e0fa1b6 and pushed to main and committed c9aa1d2 and pushed to 11.x. Thanks!

This didn't apply clean to 11.3.x, so did not backport there.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.