Problem/Motivation

Runtime requirements uses drupal_load_updates to check for runtime requirements, but drupal_load_updates only loads files with update hooks.

Steps to reproduce

Proposed resolution

Properly load all install files before running the install requirements

Remaining tasks

Confirm this is eligible for no tests since this is very hard to set a test up for, but it is pretty clear what is missing.

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3566140

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan opened merge request !14247

nicxvan’s picture

nicxvan commented
Issue summary: View changes
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

I think we can get this in without explicit tests. I think it's actually not really possible yet to make this fail, thanks to more or less accidentally baking in automatic loading of include files with hooks in the initial implementation of the OOP hooks, before we added explicit support for hook_hook_info(). It would only fail in combination with #3550311: Explore deprecating hooks in .inc files in D12.

It's a temporary workaround, in D13, we can drop this because hook_requirements() will be gone by then and the ability to have hooks in .install or other include files.

  • catch committed 3e0d3191 on 11.x 
    fix: #3566140 Properly include install files for runtime requirements...

catch closed merge request !14247

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.