Problem/Motivation

Steps to reproduce

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/contrib/antibot/

FILE: /web/modules/contrib/antibot/README.md
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
40 | WARNING | Line exceeds 80 characters; contains 93 characters
----------------------------------------------------------------------------------

FILE: /web/modules/contrib/antibot/src/Form/AntibotSettings.php
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
61 | ERROR | [x] Expected 1 blank line after function; 2 found
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/antibot/antibot.module
-------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
205 | ERROR | [x] Expected 1 newline at end of file; 0 found

Issue fork antibot-3566033

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

augustinfotech created an issue. See original summary.

elfakhar made their first commit to this issue’s fork.

nisha_j made their first commit to this issue’s fork.

nisha_j opened merge request !36

nisha_j’s picture

nisha_j commented

Verified there are no syntax errors or PHPCS violations after the changes.

Thanks,

elfakhar’s picture

elfakhar commented
Status: Active » Needs review
paraderojether’s picture

paraderojether commented
Status: Needs review » Needs work

Hi

I reviewed MR!36, and it passed on Gitlab CI. However there are still remaining PHPCS issues reamaing after running Jether@PrometSources-MacBook-Pro-4 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig antibot

FILE: /Users/Jether/Q1/q1issues/web/modules/contrib/antibot/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 50 | WARNING | Line exceeds 80 characters; contains 177 characters
 75 | WARNING | Line exceeds 80 characters; contains 111 characters
----------------------------------------------------------------------

Time: 126ms; Memory: 12MB

Jether@PrometSources-MacBook-Pro-4 contrib %

Kindly check and advise, please.
Thank you.

shamir.vs made their first commit to this issue’s fork.

shamir.vs’s picture

shamir.vs commented
Status: Needs work » Needs review

I have created a merge request. Please take a moment to review it. Thank you!

danrod’s picture

danrod
Location Ottawa
commented
Version: 3.0.x-dev » 2.0.x-dev
danrod’s picture

danrod
Location Ottawa
commented

I reviewed the changes and tested them locally and found no issues, the changes in the README.md and antibot.module makes sense to me, thanks a lot to everyone involved, I'll merge this to the 2.0.x branch.

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs review » Reviewed & tested by the community
danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.