Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3565604

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !14219

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

pretty straight forward.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 3af56067738 to main and b291c4c4058 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14219

  • longwave committed b291c4c4 on 11.x 
    refactor: #3565604 Remove an unnecessary isset() from Renderer::doRender...

  • longwave committed 3af56067 on main 
    refactor: #3565604 Remove an unnecessary isset() from Renderer::doRender...
mstrelan’s picture

mstrelan commented

There are 47 other similar violations:

$ grep 'isset.variable' core/.phpstan-baseline.php | wc -l
47

Opened #3569099: Fix all isset.variable phpstan violations to address them.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.