Problem/Motivation

Implement the help hook.

CommentFileSizeAuthor
#11 after_patch.png315.56 KBparaderojether
#11 before_patch.png301.78 KBparaderojether
#9 3565160-menu-select-hook-help.patch2.88 KBakshay kashyap
#8 after_patch.png327.43 KBshamir.vs
#6 menu-select-not-display-help-text.png138.66 KBakshay kashyap

Issue fork menu_select-3565160

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andrii momotov created an issue. See original summary.

andrii momotov’s picture

andrii momotov commented
Assigned: Unassigned » andrii momotov

I assigned the task myself because I plan to fix this issue and make a Merge Request.
Please do not work on this issue.

andrii momotov opened merge request !15

andrii momotov’s picture

andrii momotov commented
Assigned: andrii momotov » Unassigned
Status: Active » Needs review

Created MR. Pleaser review. Thanks!

akshay kashyap’s picture

akshay kashyap commented
Assigned: Unassigned » akshay kashyap
akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new menu-select-not-display-help-text.png138.66 KB

I merged the merge request and tested it on my local system; however, it is not working. After merging the merge request, the help content is not being displayed. I have attached a screenshot for reference—please review and verify.

I am using Drupal version 10.6.2-dev.

akshay kashyap’s picture

akshay kashyap commented
Status: Needs review » Needs work
shamir.vs’s picture

shamir.vs commented
Status: Needs work » Needs review
StatusFileSize
new after_patch.png327.43 KB

I verified the merge request, merged it, and tested it on my local system. It is working as expected. I am using Drupal version 10.5.7.

After Patch

akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new 3565160-menu-select-hook-help.patch2.88 KB

I have created a patch. Please review it.

andrii momotov’s picture

andrii momotov commented
Assigned: akshay kashyap » Unassigned

I checked locally in the branch from which I created this merge request https://git.drupalcode.org/project/menu_select/-/merge_requests/15, and everything works fine.

However, to be absolutely sure that it works for everyone, I made a small change to my PR. Thanks Akshay kashyap.

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png301.78 KB
new after_patch.png315.56 KB

Hi

I reviewed MR!15, and confirmed it is applied, and the hook help on the module list is added successfully. 

Jether@PrometSources-MacBook-Pro-4 menu_select % curl https://git.drupalcode.org/project/menu_select/-/merge_requests/15.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1729    0  1729    0     0   2931      0 --:--:-- --:--:-- --:--:--  2930
patching file menu_select.module
Jether@PrometSources-MacBook-Pro-4 menu_select %

Moving this to RTBC!
Thank you.

andrii momotov’s picture

andrii momotov commented
Status: Reviewed & tested by the community » Fixed

Thanks to everyone!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.