Problem/Motivation

The first parameter for SystemAdminMenuBlockAccessCheck::access() is described as The cron key. but that is not the correct description for \Drupal\Core\Routing\RouteMatchInterface $route_match.

Proposed resolution

Change the description to The route match object to be checked. which is the same description used in CustomAccessCheck::access().

Issue fork drupal-3564926

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

avpaderno opened merge request !14177

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Nice find!

quietone’s picture

quietone commented
Category: Task » Bug report

  • quietone committed 4be0b2eb on 11.3.x 
    fix: #3564926 Fix the documentation for SystemAdminMenuBlockAccessCheck...

  • quietone committed 4f6651dc on 11.x 
    fix: #3564926 Fix the documentation for SystemAdminMenuBlockAccessCheck...
quietone’s picture

quietone commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks for improving the docs!

Committed to 11.x and cherry picked to 11.3.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone closed merge request !14177

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.