there are a number of deprecated code issues relative to php version 8.4
I ran php -l on this module with php 8.4 and got these deprecation issues:
Deprecated: Non-canonical cast (integer) is deprecated, use the (int) cast instead in ./contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/AgeTracker.php on line 80
Deprecated: Non-canonical cast (integer) is deprecated, use the (int) cast instead in ./contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/AgeTracker.php on line 80
Deprecated: Non-canonical cast (integer) is deprecated, use the (int) cast instead in ./contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/AgeTracker.php on line 94
Deprecated: Non-canonical cast (integer) is deprecated, use the (int) cast instead in ./contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/AgeTracker.php on line 94
each error indicates how to fix it
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | side_by_side_Diff.png | 393.74 KB | will_frank |
| #13 | pantheon_advanced_page_cache_yours.patch | 1.16 KB | will_frank |
| #13 | pantheon_advanced_page_cache_mine.patch | 1.22 KB | will_frank |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare changes, plain diff MR !15 / changes, plain diff MR !16compare 
Comments
Comment #2
yusuf_khan commentedworking on it
Comment #6
yusuf_khan commentedhttps://git.drupalcode.org/issue/pantheon_advanced_page_cache-3564796/-/... - @maintainer please review my commit im not sure from which branch to create a MR
Comment #9
yusuf_khan commented@will_frank
please review my commit im not sure from which branch to create a MR
Comment #10
will_frank commented@yusuf_khan when I tried to apply the diff patch from merge request !16 it didn't work.
Perhaps this is due to the branch used to create the MR as you mentioned.
Comment #11
will_frank commented@yusuf_khan when I tried to manually apply the changes in the diff from request !16 then
the deprecation errors no longer appeared when I ran php -l on this module with php 8.4.
So if the problem with the diff can be addressed these changes should work.
Comment #12
yusuf_khan commentedThanks for testing, @will_frank.
When I try to create a MR and compare it with the 32x branch, I see other unrelated commits included as well, so I’m not sure which branch to base the MR on to keep it clean.
Do you have a suggestion for which branch I should use as the base so the diff applies correctly or better maintainer can help us on this?
Comment #13
will_frank commented@yusuf_khan I created a patch of the same changes for my code base which does apply correctly.
I've attached that patch file (pantheon_advanced_page_cache_mine.patch) as well as the patch from
your mr (pantheon_advanced_page_cache_yours.patch) and finally a side-by-side visual diff of the two
patches. I hope this helps. I've already said that the version of this module I'm using is Pantheon Advanced Page Cache 2.3.4
but I don't have any insight on which branch to use.
Comment #14
afinnarn commentedSee https://github.com/pantheon-systems/pantheon_advanced_page_cache/pull/81
I'm not sure this issue queue is active anymore? "SITE-5197" linked to Jira, which I cannot authenticate to...but if PHP 8.5 deprecations are being worked on, wouldn't that include PHP 8.4?
Comment #15
afinnarn commentedI just posted https://www.drupal.org/project/pantheon_advanced_page_cache/issues/3606171 as I think this issue queue has outdated information, or not accurate when considering updates on GitHub. Not sure if I am right, but I am no longer going to look through these issues vs looking on GitHub.
Comment #16
metasimThank you so much for your contributions.
Just cut a release 2.4.0 that fixes this issue.
Apologies for the slow responses in the issue queue, we are working on new processes to ensure that we stay on top of issues on drupal.org and github.