Problem/Motivation

Trash is getting in the way of other integrations by overriding the singular entity manager class.

Just like the inline comment says, it should really be using service decoration. Lets action that, since its blocker was D10, and D10 is minimum nowadays.

Proposed resolution

Ensure minimum Drupal core versions are set in info.yml and composer.json
Action change to service decoration.

Remaining tasks

Change to service decoration.

User interface changes

None

API changes

None

Data model changes

None

Issue fork trash-3564263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Issue tags: -Novice

Probably not, actually.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#3564264: Fix concrete typehinting of EntityTypeManager

Take note of #3564264: Fix concrete typehinting of EntityTypeManager, but there are ways around it without patching core.

dpi opened merge request !90

dpi’s picture

dpi
Location Perth, Australia
commented

I'm not that invested in this project; merely a drive by. So may not action feedback personally.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review

amateescu made their first commit to this issue’s fork.

  • amateescu committed 9e7ffdb9 on 3.1.x authored by dpi 
    feat: #3564263 Action todo: change entity type manager class override to...
amateescu’s picture

amateescu commented
Title: Action todo: change entity manager class override to service decoratation » Action todo: change entity type manager class override to service decoration
Status: Needs review » Fixed

Merged into 3.1.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dpi’s picture

dpi
Location Perth, Australia
commented

Great thanks @amateescu

Looks like it was cherry picked to 11.3, so you can opt to start a 11.3 minimum series for Trash

amateescu’s picture

amateescu commented

Right, but I'll have to wait for 11.3.3 to be released :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

amateescu’s picture

amateescu commented
Status: Closed (fixed) » Needs work

Drupal 11.3 is out now, we can finish this cleanup.

amateescu opened merge request !109

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
amateescu’s picture

amateescu commented
Title: Action todo: change entity type manager class override to service decoration » Change entity type manager class override to service decoration

  • amateescu committed 91bff572 on 3.1.x 
    fix: #3564263 followup - Require Drupal 11.3.3 and clean up the...
amateescu’s picture

amateescu commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.