Problem/Motivation

For our project we have custom flood events, but we only want to see user flood events in the Flood unblock table so the list is not to long. We want to filter on certain events.

Steps to reproduce

Go to the FloodUnblockAdminForm. Open the filter, there is no 'Event' filter.

Proposed resolution

Add a filter on the 'Event' field, same as on the identifier field (like query).

Remaining tasks

Write the code.

User interface changes

Filter events is added on the FloodUnblockAdminForm.

API changes

-

Data model changes

-

Issue fork flood_control-3564065

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anneke_vde created an issue. See original summary.

anneke_vde opened merge request !60

anneke_vde’s picture

anneke_vde commented

I have added an event filter to the Flood Unblock Admin Form.
You can now for example filter on 'user' events.

anneke_vde’s picture

anneke_vde commented
Status: Active » Needs review
anneke_vde’s picture

anneke_vde commented
Assigned: anneke_vde » Unassigned
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +finalist-sprint

Thanks for this contribution.

I tested this and it works well, so I'll set it RTBC.

This reminds me that the documentation is not completely covering all the functionalities of the module. I will make a new issue for this.

I also noticed that there is no test coverage for the flood unblock page. I'll make another issue for that one.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Related issues: +#3565940: Update documentation, +#3564198: Increase test coverage
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.