When installing this module on a Drupal 11.2.x version, the website crashes when using the "Add block" link.
#3507651: Error on "Add block" link already fixed Drupal 11 support, but there was a change for 11.2.x. Drupal 11.2.x is now using a construct and expects the calls to the class to have parameters => https://git.drupalcode.org/project/drupal/-/blob/11.2.x/core/modules/nav...
/admin/config/user-interface/navigation-blocknavigation_extra_plugin_filter_block__layout_builder_alter on $navigation_hooks = new \Drupal\navigation\Hook\NavigationHooks(); where the class expects parameters in Drupal 11.2.xExpand the DeprecationHelper to support Drupal 11.1 and provide the default with parameters.
Provide and review MR
N/A
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | error-on-drupal-11.3.3-without-patch.png | 83.12 KB | dtfabio |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
tim-dielsComment #4
tim-dielsAdded first draft of code. But feels not ok to have a BC check inside a BC check. Never done this before so don't know if thats the correct way to do it.
Pipelines fail not directly of my code changes, the issues were there before.
Comment #5
dtfabio commentedComment #6
dtfabio commentedHi Tim,
I tested the code change on three different Drupal instances and it worked on all three.
Drupal core versions: 10.3.14, 10.6.3 and 11.3.3
PHP versions: 8.3.30 (10.3) and 8.4.18 for the newer core versions.
Database version: MariaDB 11.8.6
Without the patch, I get the following error on core version 11.3.3:
After adding the patch, the error disappeared and it is now possible to add a block.
So I think this ticket can be moved to RTBC.
Greetings,
Fabio
Comment #8
tim-diels