Problem/Motivation

When attempting to delete a Web Push subscription entity via the admin UI, Drupal throws an error indicating that the route parameter web_push_subscription was not converted. As a result, the delete confirmation form cannot be rendered and the entity cannot be deleted through the UI.

Steps to reproduce

  1. Enable the Web Push module (version 2.0.0).
  2. Create one or more Web Push subscription entities.
  3. Navigate to /admin/content/web_push_subscription/list.
  4. Click the Delete operation for any subscription.

Proposed resolution

Define the web_push_subscription route parameter as an entity parameter in web_push.routing.yml, ensuring proper parameter conversion for the delete route.

Remaining tasks

  • Review and commit the attached patch.

User interface changes

None. This change restores expected behaviour of the existing delete UI.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
3389792-Fix-the-web_push_subscription-parameter-was-not-conv.patch796 bytesoscarclement

Issue fork web_push-3563915

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

oscarclement created an issue. See original summary.

oscarclement’s picture

oscarclement commented

This is the error message:

{
  "message": "The \"web_push_subscription\" parameter was not converted for the path \"/admin/content/web_push_subscription/{web_push_subscription}/delete\" (route name: \"entity.web_push_subscription.delete_form\")"
}

yfiervil made their first commit to this issue’s fork.

yfiervil opened merge request !15

  • yfiervil committed 291f88ab on master 
    #3563915 : fix parameter not converted on delete route
yfiervil’s picture

yfiervil commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

yfiervil’s picture

yfiervil commented
Status: Fixed » Closed (fixed)
oscarclement’s picture

oscarclement commented

Hi, I noticed that the fix for this issue was included in the 2.1.0 release. Could you please credit my account (oscarclement) in the 'Credit & committing' section of this issue so it appears on my profile? Thank you!