Thanks for this great module! The "Mark as ignored" / "Mark as OK" functionality looks really handy!
Problem
It looks like only one user can mark an alert as "Ignored". If two users mark the same alert as "Ignored" then it will still show up as active for one of them.
Steps to reproduce
- Create content with an accessibility alert:
- Enable editoria11y module
- Go to
/node/add/page - Create a page with an accessibility alert (e.g. skip a heading level)
- Create 2 users (say, UserA and UserB):
- Go to
/admin/people/create - Create the 2 users
- Grant the permissions below to these 2 users:
View Editoria11y checkerMark as hidden in Editoria11yManage Editoria11y results
- Go to
- Make UserA ignore the alert:
- Sign in as UserA
- View the page - Editoria11y will report the accessibility alert
- Click "Mark as Ignored" - this will clear the alert as expected
- Go to
/admin/reports/editoria11y/dismissals- the alert will be listed as hidden by UserA as expected
- Make UserB ignore the alert:
- Sign in as UserB
- View the page - Editoria11y will report the accessibility alert
- Click "Mark as Ignored" - this will clear the alert as expected
- Go to
/admin/reports/editoria11y/dismissals- Expected result: the alert will be listed as hidden by both UserA and UserB
- Actual result: the alert is listed as hidden only by UserA
- Check whether the alert is still ignored by UserA:
- Sign in as UserA
- View the page
- Expected result: the alert is still ignored
- Actual result: the alert is now active (yellow)
In a nutshell:

Proposed resolution
I am guessing the database model should allow for multiple users to ignore the same alert ID.
| Comment | File | Size | Author |
|---|---|---|---|
| editoria11y_mark_as_ignored.png | 82.69 KB | fengtan |
Comments
Comment #2
itmaybejj commentedOh goodness. Thank you for reporting this and documenting it well enough to quickly troubleshoot. It looks like the dismissal API is missing UID as a key for the upsert for the ignore action, so it just transfers the dismissal to the last user to dismiss it.
This is an easy fix; I'll work on getting a tagged release out in the next week or so.
Comment #3
fengtanAwesome, thanks!
Comment #6
itmaybejj commentedFixed in 2.2.19