Problem/Motivation

The media_duplicates.schema.yml file currently uses the schema type bool for several configuration keys. However, bool is not a valid configuration schema type in Drupal — the correct type is boolean.

As a result, schema validation tools (such as Config Inspector) report errors or warnings for otherwise valid Media Duplicates configuration.

Affected configuration keys

The following keys are affected:

restrict_duplicates
restrict_new_media_only
compare_within_bundle_only

Steps to reproduce

  1. Install and enable the Media Duplicates module.
  2. Navigate to Reports → Configuration inspector.
  3. Inspect the media_duplicates.settings configuration.
  4. Observe schema validation warnings related to invalid bool types.

Proposed resolution

A patch is attached that updates the schema types accordingly. This patch replaces the invalid bool schema type with the correct boolean type for the affected configuration keys in media_duplicates.schema.yml.

Remaining tasks

Review the patch.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3563721-media-duplicates-fix-bool-schema.patch648 bytesthefancywizard

Issue fork media_duplicates-3563721

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

thefancywizard created an issue. See original summary.

thefancywizard’s picture

thefancywizard commented
StatusFileSize
new 3563721-media-duplicates-fix-bool-schema.patch648 bytes

Attaching patch.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 2.0.3 » 2.x-dev
Status: Needs review » Needs work

Thanks @thefancywizard could you turn this into a MR please instead of a patch?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Code-wise the fix is correct and I can confirm the issue. RTBC afterwards!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Reviewed & tested by the community

I did that.

anybody opened merge request !21

  • anybody committed e30cebba on 2.x 
    feat: #3563721 Fix invalid 'bool' schema types in media_duplicates...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.