Problem/Motivation

#3523614: [CI] Collect and report deprecation statistics and details is telling us some of the patterns in the .deprecation-ignore.txt file are not matched by any test.

Proposed resolution

Check and remove them if not necessary.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3563647

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Version: 11.3.x-dev » 11.x-dev

mondrake opened merge request !14121

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented

#3551596: Add return types to core/tests code via Rector - round 1 has added void return types to methods in classes extending from Mink, so the deprecation is no longer triggered.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, 11,x and 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14121

smustgrave’s picture

smustgrave commented

Not seeing the commit notifications that gitlab being slow or a change to main?

catch’s picture

catch
he/him
Primary language English
commented

It was me being slow :)

  • catch committed 3575e845 on 11.3.x 
    task: #3563647 Remove unneeded patterns from deprecation-ignore.txt

By...

  • catch committed 6f51c443 on 11.x 
    task: #3563647 Remove unneeded patterns from deprecation-ignore.txt

By...

  • catch committed 9fd9c650 on main 
    task: #3563647 Remove unneeded patterns from deprecation-ignore.txt

By...
smustgrave’s picture

smustgrave commented

Sorry! Lol I just been trying to check on emails with this switch to main for weirdness.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.