Closed (fixed)
Project:
Varbase Media
Version:
10.1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Dec 2025 at 21:41 UTC
Updated:
22 Jul 2026 at 15:55 UTC
Jump to comment: Most recent
The existing iframe implementation did not include required accessibility attributes (title and lang), leading to WCAG-related errors reported by automated accessibility tools such as Acquia Web Governance.
Implemented title and lang attributes on the iframe to address accessibility compliance issues identified by tools like Acquia Web Governance.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
ahmad.estaitia commentedComment #4
ahmad.estaitia commentedComment #8
rajab natshahI merged the MR
But followed up with the Full testing round
Having the following may hit a performance issue in projects, If we have 10-20 iframe(s) in the same page
As this will call the resource server ( Youtube, Vimeo, ... ) to get the title from the remote server.
On every load for the page.
Maybe - better to remove this.
I do not recommend using a local patch for this MR in projects.
We had a case before, but was managed with
hook_entity_presaveEasy direction to remove the Add media title from resource if available. ( as we do not want to have any new cache buffer fields )
Comment #9
rajab natshahComment #10
rajab natshah➖ Performance
Having this will bring a performance issue.
Comment #11
rajab natshahOne more option:
Comment #12
josebc commentedHello, some small comments
- Duplicate checks for langcodes, remove logic from twig
- Use media entity label instead of OEmbed to allow admins to edit and translate
Comment #13
rajab natshah✅ Released varbase_media-10.1.2