Problem

It seems some recent changes in Canvas results in an incompatibility:

Time: 01:25.870, Memory: 22.00 MB
There were 2 errors:
1) Drupal\Tests\custom_elements\Kernel\CanvasIntegrationTest::testCanvasExtJsComponentConversion
ArgumentCountError: Too few arguments to function Drupal\canvas\Plugin\Canvas\ComponentSource\GeneratedFieldExplicitInputUxComponentSourceBase::__construct(), 8 passed in /builds/project/custom_elements/web/modules/contrib/canvas_extjs/src/Plugin/Canvas/ComponentSource/ExternalJavaScriptComponent.php on line 79 and exactly 9 expected
/builds/project/custom_elements/web/modules/contrib/canvas/src/Plugin/Canvas/ComponentSource/GeneratedFieldExplicitInputUxComponentSourceBase.php:102
/builds/project/custom_elements/web/modules/contrib/canvas_extjs/src/Plugin/Canvas/ComponentSource/ExternalJavaScriptComponent.php:79
/builds/project/custom_elements/web/modules/contrib/canvas_extjs/src/Plugin/Canvas/ComponentSource/ExternalJavaScriptComponent.php:95
/builds/project/custom_elements/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/builds/project/custom_elements/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:85
/builds/project/custom_elements/web/core/lib/Drupal/Core/Plugin/DefaultSingleLazyPluginCollection.php:62
/builds/project/custom_elements/web/core/lib/Drupal/Component/Plugin/LazyPluginCollection.php:80
/builds/project/custom_elements/web/core/lib/Drupal/Core/Plugin/DefaultSingleLazyPluginCollection.php:83
/builds/project/custom_elements/web/core/lib/Drupal/Core/Plugin/DefaultSingleLazyPluginCollection.php:99
/builds/project/custom_elements/web/core/lib/Drupal/Core/Plugin/DefaultSingleLazyPluginCollection.php:55
/builds/project/custom_elements/web/modules/contrib/canvas/src/Plugin/VersionedConfigurationSubsetSingleLazyPluginCollection.php:37
/builds/project/custom_elements/web/modules/contrib/canvas/src/Entity/Component.php:256
/builds/project/custom_elements/web/modules/contrib/canvas/src/Entity/Component.php:271
/builds/project/custom_elements/web/modules/contrib/canvas/src/Entity/VersionedConfigEntityBase.php:184
/builds/project/custom_elements/web/modules/contrib/canvas/src/Entity/Component.php:518

Steps to reproduce

- see custom_elements tests

Proposed resolution

- we should fix + update the tests of canvas_extjs to run against canvas 1.x dev version as well (like custom_elements)

Issue fork canvas_extjs-3563480

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented

this is the reason: https://www.drupal.org/node/3556891

fago opened merge request !14

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

  • fago committed e1406d12 on 1.x 
    fix: #3563480 Update for compatibility with latest canvas 1.x-dev...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Merged! It also runs tests with 1.x-dev now, so we shoudl catch issues like this earlier in the future.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.