Problem/Motivation

This is a security related module, so I think it should have automated tests.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork social_auth_google_one_tap-3563059

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Status: Active » Needs review

Added a generic test and the gilab-ci.yml.

grevil opened merge request !2

grevil’s picture

grevil commented
Status: Needs review » Postponed

composer.json adjustments are already done in #3563136: Module assesement and best practice "overhaul".

Postponed on that issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Postponed » Needs review

Copied them over so this one can already run and be merged if fine.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Nice, all green! Good foundation!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

After merging this, it might make sense to have module-specific tests for anonymous users, e.g. that the JS is loaded etc. Might happen in a follow-up issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

We're maintainers now, merging!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.