Problem/Motivation

#3365985: Promote justinrainbow/json-schema from dev-dependency to full dependency added justinrainbow/json-schema as a dependency of the root composer.json, but this is only used by core developers.

Core's runtime dependencies should be added to core/composer.json so users depending on drupal/core will have them installed.

Steps to reproduce

Proposed resolution

Move justinrainbow/json-schema to core/composer.json.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3562627

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !14087

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

We need to do this but I also think we should open an 11.3.x-only MR to remove it from production dependencies again, because the issue that will use it isn't in yet (although it is RTBC). That way the dependency, feature, and #3472008: Avoid JSON:API schema validation by default when assert is enabled can all land together in 11.4.x

godotislate made their first commit to this issue’s fork.

godotislate opened merge request !14110

godotislate’s picture

godotislate
he/him
commented

MR 14110 against 11.3.x to move justinrainbow/json-schema back to dev packages.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks 11.3.x MR also looks good.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Needs change record updates

Was there a change record for moving it to a runtime dependency? If so that needs updating, tagging for that.

  • longwave committed d1000ec8 on 11.x 
    fix: #3562627 Move justinrainbow/json-schema to core/composer.json

By:...
catch’s picture

catch
he/him
Primary language English
commented

There wasn't a change record, so I created one and referenced both the original issue and this one https://www.drupal.org/node/3563143

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs change record updates

Committed and pushed d1000ec80ec to 11.x. Thanks!

Also pushed 7a7152db253 tagged as a revert of #3365985: Promote justinrainbow/json-schema from dev-dependency to full dependency.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.