Problem/Motivation

There are some leftovers from #3538360: Profile & Instance naming normalization. Mainly "tree node" still being called "instance" when it is also the name of an entity.

Proposed resolution

Is the release of beta1 the good opportunity to clean this up a bit?

Let's focus on comments and PHP Interfaces for this MR. It will be enough for now and we don't want to make a mess so close from first beta.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Assigned: pdureau » mogtofu33
Status: Active » Needs review

I did a bit more than only PHP interfaces, but i didn't touch the islands plugin themselves, to stay safe.

I don't know if it this task is better being merged before beta1 (to provide stable interfaces and to avoid complex rebasing later in the project) of after beta1 (to not introduce some risk and instability before shipping) :

mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mogtofu33 committed 3b318a82 on 1.0.x authored by pdureau
    chore: #3561854 Node & Instance naming normalization
    
    By: pdureau
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.