Problem/Motivation

Sites may want to show student's past certificates, so we should allow it to be configured for displays and views.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork lms_certificate-3561762

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

luke pekrul created an issue. See original summary.

catch made their first commit to this issue’s fork.

catch opened merge request !4

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Title: Allow for certificates to be configured for display » Implement field access for certificate field

The field currently can't be configured for display but that's a core bug with bundle fields. Once it can be, we want field access so it only shows when you're going to be able to download something.

graber’s picture

graber commented
Status: Needs review » Reviewed & tested by the community

Looks good!

catch’s picture

catch
he/him
Primary language English
commented

Made one more change to add a trait for the certificate access, wasn't entirely sure how much code could change but it reduces quite a lot of duplication in the end - just needs the group and user, then does the rest.

graber’s picture

graber commented
Status: Reviewed & tested by the community » Needs work
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Fixed the typos/cs issues - green pipeline now.

graber’s picture

graber commented
Status: Needs review » Fixed

Merge train on the way.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • graber committed b95e9190 on 1.0.x authored by catch 
    Issue #3561762: implement hook_entity_field_access()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.