Problem

The recent improvements to the auto-formatter have lead to some issues on production. Some attributes, rendering first into slots, are not output correctly any more.

Issue fork custom_elements-3561665

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago opened merge request !158

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: auto formatter fails for some fields » With 3.3.0 the auto formatter may fail for some fields
Status: Active » Needs review

Turns out getAttribute() was not doing the same key normalization like setAttribute()! Fixed this + added test coverage.

  • fago committed 2b704cf6 on 3.x 
    fix: #3561665 fix getAttribute to normalize the key correctly

fago opened merge request !159

  • fago committed 1bbc3de2 on 3.x 
    fix: #3561665 Fix fatal error when rendering JSON preview at display...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Got this fixed. there was a second issue with slotes names not being mapped correctly. I added a test case for it and merged the fix.

I accidentally merged this with the wrong commit message "Fatal error when rendering JSON preview at display edit form" though. :-(

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.