Problem/Motivation

Dumping the queries on the umami front page performance test, I noticed this query runs twice sequentially. Didn't look at what's calling key/value in hook discovery yet, but we can probably get it to once easily enough.

+    89 => 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "theme_hook_list" ) AND "collection" = "hook_data"',
+    90 => 'SELECT "name", "value" FROM "key_value" WHERE "name" IN ( "theme_hook_list" ) AND "collection" = "hook_data"',

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comments

catch created an issue. See original summary.

nicxvan’s picture

nicxvan commented

We set them here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

We get it here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

And here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

We need the list in Registry and ThemeManager.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

We could use the cache in the registry, I didn't do that because it's only needed on a theme build. Would still mean a query to look it up, not sure that's really much different and worth the complexity? It really shouldn't be more than two.

nicxvan’s picture

nicxvan commented

Just checking in to see if we want to update this?

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

nicxvan’s picture

nicxvan commented
Status: Active » Closed (duplicate)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.