Style plugin attachTo() not being invoked

Added a commit to disable the attachment feature if the Views Data Export module is not enabled.

Wondering why we have that dependency on the Views Data Export module in the Excel Export style in the first place...

What about creating a Views Data Export Excel module? What do you think?

I would like to avoid creating a strong dependency between between XLS Serialization and Views Data Export as some people might only be interested in the Excel serializer don't want the burden of Views Data Export and all its dependencies like CSV Serialization.

I would rather create a new contrib module depending on XLS Serialization and Views Data Export.

Pushed an MR adding two traits allowing to avoid code duplication in this new module: #3561090: Use traits for style and display plugins to facilitate code reuse.

I have something working that requires only a few lines of code.

I have created the Views Data Export Excel module.

Here is the related code for both the new style and display, there is almost no duplication of code:

<?php

namespace Drupal\views_data_export_excel\Plugin\views\style;

use Drupal\views_data_export\Plugin\views\style\DataExport;
use Drupal\xls_serialization\Plugin\views\style\ExcelExportStyleTrait;

/**
 * A style plugin for Excel export views.
 *
 * @ingroup views_style_plugins
 *
 * @ViewsStyle(
 *   id = "data_export_excel",
 *   title = @Translation("Data Export Excel"),
 *   help = @Translation("Configurable row output for Excel exports."),
 *   display_types = {"data"}
 * )
 */
class ExcelExport extends DataExport {

  use ExcelExportStyleTrait;

  /**
   * Constructs a Plugin object.
   *
   * @param array $configuration
   *   A configuration array containing information about the plugin instance.
   * @param string $plugin_id
   *   The plugin_id for the plugin instance.
   * @param mixed $plugin_definition
   *   The plugin implementation definition.
   * @param mixed $serializer
   *   The serializer for the plugin instance.
   * @param array $serializer_formats
   *   The serializer formats for the plugin instance.
   * @param array $serializer_format_providers
   *   The serializer format providers for the plugin instance.
   * @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
   *   The module handler service.
   */
  public function __construct(
    array $configuration,
    $plugin_id,
    $plugin_definition,
    $serializer,
    array $serializer_formats,
    array $serializer_format_providers,
    $module_handler,
  ) {
    parent::__construct(
      $configuration,
      $plugin_id,
      $plugin_definition,
      $serializer,
      $serializer_formats,
      $serializer_format_providers,
      $module_handler,
    );

    $this->initializeSerializerFormats();
  }

}

<?php

namespace Drupal\views_data_export_excel\Plugin\views\display;

use Drupal\Core\Form\FormStateInterface;
use Drupal\views_data_export\Plugin\views\display\DataExport;
use Drupal\xls_serialization\Plugin\views\display\ExcelExportDisplayTrait;

/**
 * Provides an Excel export display plugin.
 *
 * This overrides the Data Export display to make labeling clearer on the admin
 * UI, and add specific Excel-related functionality.
 *
 * @ingroup views_display_plugins
 *
 * @ViewsDisplay(
 *   id = "data_export_excel",
 *   title = @Translation("Data Export Excel"),
 *   help = @Translation("Export the view results to an Excel file."),
 *   uses_route = TRUE,
 *   admin = @Translation("Data Export Excel"),
 *   returns_response = TRUE
 * )
 */
class ExcelExport extends DataExport {

  use ExcelExportDisplayTrait;

  /**
   * Overrides the content type of the data response.
   *
   * @var string
   */
  protected $contentType = 'xlsx';

  /**
   * {@inheritdoc}
   */
  public function buildOptionsForm(&$form, FormStateInterface $form_state) {
    parent::buildOptionsForm($form, $form_state);

    switch ($form_state->get('section')) {
      case 'style':
        $this->buildStyleSectionForm($form, $form_state);
        break;

      case 'path':
        // Use default Views Data Export form.
        break;

      case 'format_header':
        $this->buildFormatHeaderSectionForm($form, $form_state);
        break;
    }

    $this->buildConditionalFormattingRulesForm($form, $form_state);
  }

}

Could you give it a try and tell me how it goes for you?

Views Data Export Excel 1.0.0-rc1 has been released.

If it solves the problem we will be able to mark this issue's as "Won't fix".

Views Data Export 1.0.0 has been released. Closing.