Problem/Motivation

There's a lot of potential for code and text re-use across various mechanisms of self-declaration (checkout, user tab, and [later] standalone anon. We can also improve the display of these forms (copied this part in from #3560172: Better UX on donor own view).

Proposed resolution

Share template/theme, and a settings UI could control default text.

Improve the display when a donor views themselves:

  • A Gift Aid focused section at the top that combines text about what Gift Aid is, whether it is currently being claimed, with buttons for making a declaration or cancelling as appropriate.
  • An address section below with a 'Change address' button.
  • Instead of the 4 states. Either it is ongoing and they can cancel or it is not and they can declare.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gift_aid-3560176

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathanshaw created an issue. See original summary.

adamps’s picture

adamps commented

Common UX. Put settings on the charity.

adamps’s picture

adamps commented
Issue summary: View changes

adamps opened merge request !21

adamps’s picture

adamps commented

My current draft of the page:

  1. Header
  2. Status
  3. Address form
  4. Button(s)

Reason is:

  • If not declared then we need to enter an address, so the address needs to come before the button
  • If declared, then change of address seems equally likely as cancellation, so the address is still relevant. I put the address first and the buttons last because that's the way almost all forms are, and it seemed odd (and harder code) to have a button in the middle
adamps’s picture

adamps commented
Assigned: Unassigned » jonathanshaw
Status: Active » Needs review

I have kept a setting for explanation - this is important for compliance.

The rest is just a matter of UI styling. We can set a good default that suits your site. Anyone who prefers something else can write a 

hook_for
m_alter()

- which is way more flexible that settings for some strings. So I didn't put any settings, as I felt it would add unnecessary time/complexity.

I had to tweak the explanation message, so that it worked both on checkout and on user tab. Please check.

Before: I want to Gift Aid my donation and any donations I make in the future or have made in the past four years to

After: I want to Gift Aid any donations I make from now on or have made in the past four years to

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Assigned: jonathanshaw » adamps
Status: Needs review » Needs work

Left comments on the MR. I think the work related to #3560172: Better UX on donor own view and the general modernisations are good, but some of the checkout pane "unification" stuff might need to be set aside for now, I misjudged this.

adamps’s picture

adamps commented
Assigned: adamps » jonathanshaw

Strange I don't see any comments. Did you remember to complete your review?

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Assigned: jonathanshaw » adamps

Whoops, submitted review now

adamps’s picture

adamps commented
Assigned: adamps » jonathanshaw
Status: Needs work » Needs review
jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Assigned: jonathanshaw » Unassigned
Status: Needs review » Reviewed & tested by the community

That sounds workable.

adamps’s picture

adamps commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • adamps committed 5b1056f4 on 1.x 
    task: #3560176 Unify and provide a UI for self-declaration wording/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.