Problem/Motivation

When using this module in conjunction with content_moderation and content_translation it is possible to have draft content become published after running a bulk update.

Steps to reproduce

Typically we use the DrupalWxt distribution which includes these configs, if configuring by hand you will need to:

  1. Install content_moderation and create a workflow with minimally draft and published;
  2. Install content_translation and add a second language (Fr);
  3. Create a content type and set it for both moderation and translation;
  4. Create a node in En and publish it;
  5. Translate the node in Fr and publish it;
  6. Edit the French node and add 'DRAFT' to the title and save as Draft;
  7. In admin/content use VBO to bulk modify field values and add test to both the En and Fr node bodies.

The result of this test is that the Fr draft content will be published with the log message: Edited as a part of bulk operation. Field changed: body (Published)

Proposed resolution

I believe this defect is as a result of #3080995: EntityRepository::getActive does not return a translations most recent revision which does not look like it is being fixed anytime soon. However, the patch from this issue: #2797583: Dynamically provide action plugins for every moderation state change provides a method for getting the latest revision. Also, for content moderated nodes this issue #3285038: Revision checkbox may not be selectable for moderated content is relevant as creating a new revision is required for moderated content, however, I think the patch itself may need some work as it should likely check each entity to see if it is moderated and if it is ensure a new revision is created.

Remaining tasks

Automated tests.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 views_bulk_edit-incorrect_revision-3559935-2.patch3.03 KBjoel_osc

Comments

joel_osc created an issue. See original summary.

joel_osc’s picture

joel_osc commented
StatusFileSize
new views_bulk_edit-incorrect_revision-3559935-2.patch3.03 KB

Here is a patch that uses the getLatestRevision method from #2797583: Dynamically provide action plugins for every moderation state change instead EntityRepository::getActive.

joel_osc’s picture

joel_osc commented
Status: Active » Needs work

The uploaded patch is close as it works in some cases but not for the steps stated above, changing issue to needs work. The case it does work for which is where I need it is changing a non-translatable taxonomy entity reference field. Dealing with revisioning in a moderated, translated Drupal instance is really mind-bending.