Problem/Motivation

This module functionality breaks when updating from pre 1.4 to 1.5+ because htmx/drupal is now missing

Steps to reproduce

Update a site using this module according to instructions on project page and documentation from 1.4 to 1.5. All functionality will break because the htmx/drupal lib is gone.

Proposed resolution

Reintroduce the library, even if redundant.

Remaining tasks

Bring back the library.

Publish a change record.

Issue fork htmx-3559894

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

onion created an issue. See original summary.

onion’s picture

onion commented

Fwiw, I was able to get basic functionality working again by switching out htmx/drupal for core/htmx.

fathershawn made their first commit to this issue’s fork.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Thank you! I sure thought I put that in the release notes :(

I also just learned how to keep an empty library that has dependencies, so I'll get that in and create a patch version to make it easier for others.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Issue summary: View changes
Issue tags: -upgrade

fathershawn opened merge request !44

  • fathershawn committed 25b797b3 on 1.5.x 
    fix: #3559894 htmx/drupal library is missing after upgrade to 1.5
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Active » Fixed
  1. Added a CR: Deprecation: htmx/drupal and htmx/htmx library
  2. Restored an empty htmx/drupal library that depends on core/drupal.htmx
  3. Modified a test to use the restored htmx/drupal to verify that this approach works.

Thanks @onion. Note the appropriate swap value above for refactoring your attachment code to use core. Using core/htmx will not get you merged incoming assets.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

onion’s picture

onion commented

We ended creating a dependency for core/drupal.htmx in our theme library as well.

Thanks @fathershawn for the quick fix!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.