Problem/Motivation

By design, when content moderation and content translation are enabled, translation forms include only translatable fields. See https://www.drupal.org/project/drupal/issues/2878556.

ETUF attempts to make all forms the same, with all fields available. The functionality listed above conflicts with this goal.

Steps to reproduce

  1. Install content moderation and content translation
  2. Setup a content type with translatable and non-translatable fields
  3. Create content of the type created above. See the translation page doesn't include the non-translatable field.

Proposed resolution

I've provided an in-progress solution that gives ETUF an option to replace translation node edit forms with the original form. The form is translated with the interface language, as usual. So long as the moderation is synchronized, the issue fixed in https://www.drupal.org/project/drupal/issues/2878556 shouldn't be an issue.

I've seen a variety of solutions for this issue. None have worked for me. These are a few.

Remaining tasks

This is an early version of this solution. It needs to be tested.

User interface changes

A checkbox was added to the content translation configuration page, next to other ETUF options, with the label "Replace node edit"

CommentFileSizeAuthor
#2 3559833_enity_translation_unified_form__replace_node_form.patch15.86 KBbzaher
enity_translation_unified_form__replace_node_form.patch15.93 KBbzaher

Issue fork entity_translation_unified_form-3559833

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bzaher created an issue. See original summary.

bzaher’s picture

bzaher commented
StatusFileSize
new 3559833_enity_translation_unified_form__replace_node_form.patch15.86 KB

joseph.olstad made their first commit to this issue’s fork.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Wow great initiative Barry!

Creating a merge request now.

joseph.olstad opened merge request !7

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@bzaher , from the merge request, newest version of your patch.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: bzaher » joseph.olstad

Testing this now

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Status: Active » Reviewed & tested by the community

Wow, great, works well in my testing.

My only comment is, I'm wondering if we should just enable this by default rather than add a new configuration for
"Replace node edit" however maybe the approach is good, people can intentionally enable this functionality. I think it's good to merge!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Going ahead with the merge, let's cut a release!

  • joseph.olstad committed 52efe883 on 2.0.x 
    feat: #3559833 Mitigating "Fields that apply to all languages are hidden...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/project/entity_translation_unified_form/releases/...

I'll announce this now in LinkedIn, major improvement!

Thank you very much @bzaher!

bzaher’s picture

bzaher commented
Status: Fixed » Reviewed & tested by the community

Thanks for taking it the rest of the way @joseph.olstad. I considered "enable this by default" too, but my concern is that since this issue's been present for 8 years, this might interfere with the workarounds that people have found.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

https://www.drupal.org/project/entity_translation_unified_form/releases/...

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • joseph.olstad committed 4f75550d on 2.0.x 
    fix: #3559833 Update README.md for new Replace node edit functionality...
bzaher’s picture

bzaher commented
Related issues: +#2878556: Ensure that changes to untranslatable fields affect only one translation in pending revisions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.