Problem/Motivation

We're evaluating this module for possible use and found that there seems to be a redundant route /entityqueue_form_widget that doesn't seem to have much use. It's not mentioned anywhere in the code and not used in the tests, and I expect it could be removed without much issue. The main reason I'd consider using it is for operational security, to ensure that as little information about the modules used on a site is visible to the general public.

Steps to reproduce

  1. Install and enable module
  2. Visit /entityqueue_form_widget in a web browser

Entity Queue Form Widget Custom Page

Proposed resolution

Remove the route and EntityQueueFormWidgetController class.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Automated unit testing coverage
  • ✅ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release entityqueue_form_widget-2.0.8

API changes

None.

Data model changes

None.

Release notes snippet

  • fix: #3559516 Remove redundant /entityqueue_form_widget route and unused controller By: geoffreyr
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

geoffreyr created an issue. See original summary.

geoffreyr’s picture

Assigned: geoffreyr » Unassigned
Issue summary: View changes
Status: Active » Needs review

rajab natshah made their first commit to this issue’s fork.

rajab natshah’s picture

Title: Redundant route /entityqueue_form_widget? » Remove redundant /entityqueue_form_widget route and unused controller
rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new24.32 KB

Thanks, Geoffrey, for reporting and the MR
Important catch!!
I inherited co-maintaining this module at some point.

Today I had the AI touch the code for me.

claude --permission-mode bypassPermissions "use @agent-drupal-package-config-updater and keep working in the /var/www/html/products/entityqueue_form_widget"

Added

rajab natshah’s picture

Issue summary: View changes
Issue tags: +entityqueue_form_widget-2.0.8
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.