Problem/Motivation

Let's default to PHP 8.5 for testing on 11.x and 11.3.x to prevent regressions on the latest supported version of PHP.

Proposed resolution

Remaining tasks

User interface changes

N/a

Introduced terminology

N/a

API changes

N/a

Data model changes

N/a

Release notes snippet

N/a

Issue fork drupal-3559487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13929

mondrake’s picture

mondrake
Location 🇮🇹
commented

Side note: I found 8.4 and 8.5 on SQLite quite consistently failing. I think we’ll have challenges there.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work

I think a couple of glitches - see inline

mondrake’s picture

mondrake
Location 🇮🇹
commented

#3 is most database lock errors in functional/javascript tests. I have an hypothesis - PHP is faster and the db connection in the SUT is still active after a test involving sending a request returns fro the request, and the test code is trying to access the db. I will try to run tests over PHP 8.5 in #3406985: Convert all transactions in core to use explicit ::commitOrRelease() and see if explicit commit makes things any better.

mondrake’s picture

mondrake
Location 🇮🇹
commented

#6 no, explicit transaction do not seem to do any better here https://git.drupalcode.org/issue/drupal-3406985/-/pipelines/669312

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Given the extent of changes needed to support PHP 8.5, default testing on it for 11.x seems obvious. Not sure about 11.3.x - maybe we want to leave that at 8.4 which is the recommended PHP version?

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Couple of comments on the MR - looks like job names not updated when we made 8.4 the default.

I'd also lean slightly towards only making this change in 11.x and leaving 11.3 as-is per #9, but on the other hand keeping gitlab yaml in sync helps with other changes, and we have the branch jobs still.

  • catch committed 23f25b33 on 11.3.x 
    fix: #3559487 Default to PHP 8.5 for testing to prevent regressions

By...

  • catch committed a8b35bdb on 11.x 
    fix: #3559487 Default to PHP 8.5 for testing to prevent regressions

By...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Needs work » Fixed

Comments on the MR were wrongheaded from mis-reading the YAML.

Decided go backport this to 11.3.x - keeping the yaml in sync has a lot of benefits, we usually only run pipelines against 11.3.x after a backport anyway.

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13929

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.