Problem/Motivation

After install, and before running the first test, on the /admin/reports/security-review page, if you click on one of the "details" links, an exception is thrown.

TypeError: Drupal\security_review\Plugin\SecurityCheck\ErrorReporting::getDetails(): Argument #2 ($hushed) must be of type array, null given, called in /var/www/html/web/modules/contrib/security_review/src/Controller/HelpController.php on line 207 in Drupal\security_review\Plugin\SecurityCheck\ErrorReporting->getDetails() (line 75 of modules/contrib/security_review/src/Plugin/SecurityCheck/ErrorReporting.php).

Steps to reproduce

  1. Install module.
  2. Do not run a check.
  3. Go to /admin/reports/security-review and click on one of the "details".
  4. An exception is thrown.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork security_review-3559343

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mdranove created an issue. See original summary.

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !99

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Also determine the help routes were using title and that didn't seem right.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave
Status: Needs review » Needs work

  • smustgrave committed 390225d5 on 3.1.x 
    feat: #3559343 Checking test details before running test throws an...
smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.