Problem/Motivation

Same reasoning as #734080: Set preprocess: false for jquery.min.js to reduce duplication between asset aggregates. HTMX is smaller than jQuery, but the cache hit rate arguments are the same.

Visible in the performance test that specifically tests asset aggregation across multiple pages - e.g. in Umami you can end up downloading htmx twice or more without the MR, once with it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3559318

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !13912

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

OK the test that's designed to show the impact of this does in fact show the impact of this - probably big pipe is active on at least two of those pages.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

Discussed with @catch on slack that the script count goes up (as expected), and not only is there htmx now in its own file, aggregates get split.

Script bytes go down because htmx is not included in multiple aggregates and so only gets downloaded once.

lgtm

nod_ made their first commit to this issue’s fork.

  • nod_ committed 1b8f8193 on 11.3.x 
    task: #3559318 Exclude htmx from aggregation

By: catch
By: godotislate...

  • nod_ committed 83154c72 on 11.x 
    task: #3559318 Exclude htmx from aggregation

By: catch
By: godotislate
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 83154c7 and pushed to 11.x. Thanks!
Committed 1b8f819 and pushed to 11.3.x. Thanks!

We should put that in 11.2.x too, cherry pick is not clean need a dedicated MR

godotislate opened merge request !13943

godotislate’s picture

godotislate
he/him
commented
Status: Patch (to be ported) » Needs review

MR 13943 for 11.2.x, but weirdly the performance tests passed without any changes.

godotislate’s picture

godotislate
he/him
commented

Oh, right, HTMX is used in Big pipe only in 11.3.x, not 11.2.x, so that explains the performance tests.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

The 11.2 MR agrees with the 11.x MR, except for the tests as explained in #12.

  • nod_ committed 848ef64b on 11.2.x 
    task: #3559318 Exclude htmx from aggregation

By: catch
By: godotislate...

nod_ closed merge request !13943

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

Committed 848ef64 and pushed to 11.2.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

nod_ closed merge request !13912

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.