Problem/Motivation

I was surprised to see no-one reported this yet, but in IndividualGroupPermissionCalculator or IndividualGroupRoleAccessPolicy, we load the group for each membership just to get the ID. That is an unnecessary performance hit, which we should fix.

Steps to reproduce

N/A

Proposed resolution

Call getGroupRelationship->getGroupId() instead.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork group-3559040

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde opened merge request !272

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review

Will also need backports to 2.x and 3.x as its a small effort with potentially huge gains.

kristiaanvandeneynde opened merge request !273

kristiaanvandeneynde opened merge request !274

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.