Problem/Motivation

The feature_toggle condition plugin has no config schema

Steps to reproduce

  1. Install Config inspector: https://drupal.org/project/config_inspector
  2. Add a block with a feature toggle condition
  3. Inspect the block configuration

Proposed resolution

Add config schema for condition.plugin.feature_toggle

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

condition.plugin.feature_toggle uses typed data

Issue fork feature_toggle-3559008

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !21

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request adds a config schema for the feature_toggle condition plugin:

Before

  feature_toggle:
    id: feature_toggle
    features:
      disable_new_appstore_credit: disable_new_appstore_credit
    negate: 1

After

  feature_toggle:
    id: feature_toggle
    negate: false
    features:
      - disable_new_appstore_credit

  • plopesc committed ee80f477 on 3.x authored by idebr 
    Issue #3559008: Add config schema for condition.plugin.feature_toggle
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Looks great. Thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.