Problem/Motivation

In spite of trying to be really careful about it, I screwed up #3287818: Automated Drupal 10 compatibility fixes and tagged 8.x-1.7 with composer.json only supporting D8 + D9, while group_notify.info.yml claimed to also support D10 in core_version_requirement.

Steps to reproduce

Proposed resolution

Add a Unit test to parse the two files and make sure the requirement for drupal/core matches.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork group_notify-3558930

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dww created an issue. See original summary.

dww opened merge request !15

dww opened merge request !16

dww’s picture

dww
we/he/they
commented
Assigned: dww » Unassigned
Status: Active » Needs review

That was a little more fun that I bargained for. ;) The GitLab CI pipelines from the DA do all sorts of funny business with the composer.json file. I needed to add some brains to both the test and the .gitlab-ci.yml file to save a copy of the original composer.json as composer.json.orig and for the test to parse that copy, if it exists.

Once that was done, the tests are passing fine on 2.0.x branch, and failed on 8.x-1.x where the two requirements were actually still different. 😅 Pushed another commit to fix that, and we're back to all green.

  • dww committed 997f227f on 2.0.x 
    task: #3558930 Add Unit test to ensure core_version_requirement and...

  • dww committed 5151d8a0 on 8.x-1.x 
    task: #3558930 Add Unit test to ensure core_version_requirement and...

dww closed merge request !15

dww closed merge request !16

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.