Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork security_review-3558337

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

mdranove’s picture

mdranove commented
Assigned: Unassigned » mdranove

mdranove opened merge request !96

mdranove’s picture

mdranove commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Test are failing
Some phpstan failures now
I don’t see the configuration option being tested for headers

mdranove’s picture

mdranove commented
Status: Needs work » Needs review

Seems like I needed mocking to do the headers test. I wasn't really familiar with that but I got ChatGPT to help me. It seems fine?

All green now.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

2 second glance all the test are missing : void

The headers plugin has a configuration form headers_to_check that needs to be tested as well.

mdranove’s picture

mdranove commented
Status: Needs work » Needs review

Updated the headers fail test to check for X-Frame-Options and added :void.

I think it's checking for the headers config ok unless im misunderstanding.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

This one still appears to be missing coverage for the configuration.

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.