Problem/Motivation

Now as there is CI/CD integration (#3558185: Add CI/CD integration with phpcs, phpstan, linting and cspell), we need to fix the findings from pipeline jobs (see here https://git.drupalcode.org/project/highlight_js/-/pipelines/662388 for more details)

Issue fork highlight_js-3558194

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev’s picture

a.dmitriiev commented
Issue summary: View changes
ritarshi_chakraborty’s picture

ritarshi_chakraborty commented

Working on it.

ritarshi_chakraborty opened merge request !10

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented
Status: Active » Needs review

Hey @a.dmitriiev, we can disable eslint warnings by adding /* eslint-disable */ at the top of Js files. Do you want me to fix those warnings manually?

a.dmitriiev’s picture

a.dmitriiev commented

I think it would be nice to have them fixed instead of ignoring, thank you! Also it would be nice to have .cspell-project-words.txt file with all project words in them (you can take the words from the pipeline job output).

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Needs review » Needs work
ritarshi_chakraborty’s picture

ritarshi_chakraborty commented
Status: Needs work » Needs review

I have resolved all the warnings and errors!

a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Reviewed & tested by the community

@ritarshi_chakraborty thank you for taking care of all the warnings! It is nice to see green pipelines! Looks good to me. I see some problems with the copy function when just clicking on code container, but it seems that it is not related to the changes on this MR.

It will be good if @norman.lol also can double check before merging.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Reviewed & tested by the community » Fixed

Thank you! Looking good. Opening follow up for button behavior.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.