Using a taxonomy term filter results in the following notice

Notice: Trying to get property of non-object in node_filter_form() (line 221 of /Users/mdp/cvs/head/modules/node/node.admin.inc).

And the term name isn't displayed in the filter.

This patch fixes that.

CommentFileSizeAuthor
node_admin_filters.patch843 bytesmikey_p
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

Congratulations mickey_p, you have won the right to write a test for the content filter form :) Aren't you happy?

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented

Aw crap.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

After discussion with catch, we agreed that this is not the issue to write such a test. Plus, this filter form is being reworked by mickey_p (on a suggestion by chx), so the test will probably be need to be rewritten at one point.

Let's get this in and forget about it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

I love this tag. :)

mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented

FWIW, the new issue is at http://drupal.org/node/355820

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for two weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.