Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork tour-3557783

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !131

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @smustgrave!

Do we have any chance to use Drupals library system finally and not include tour.js into the module?

smustgrave’s picture

smustgrave commented

Huh?

Tour.js is always going to be needed?

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sorry @smustgrave of course I meant Shepherd.js -.- My brain and hands were disconnected :D

smustgrave’s picture

smustgrave commented

So I still needed to compile the shepherd js. I couldn’t get it working as a .mjs file. And had to play with the weights which feels dirty but appears to be working

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks, yes that seems to be sadly true. We could alternatively ask Shepherd to provide a standalone / global script build as alternative to the .mjs version?

And we need to keep in mind and inform users about the licence change! So we should not ship with the commercial version?

smustgrave’s picture

smustgrave commented

Maybe in the README but that doesn't come into play here as I'm using the same version as before.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Ok just wanted do ensure that and keep it in mind :)

smustgrave’s picture

smustgrave commented

Agreed though to drop a note makes sense.

smustgrave’s picture

smustgrave commented

Does this work for you though? And it unblock your translation issue?

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

This works perfectly and fixes our issue from #3552263: Tour strings are not translatable, should be "label" in schema! Thanks @smustgrave!

Code changes LGTM as well! RTBC!

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.