Problem/Motivation

When running security review with Drush on a site where the default language is not English, then \Drupal\security_review\Commands\SecurityReviewCommands::formatResults doesn't find the checks given in the result. The $check_name in the default language and that never matches anything.

Proposed resolution

When building the result in \Drupal\security_review\Commands\SecurityReviewCommands::securityReview, use the ID of the check plugin, not its name.

Issue fork security_review-3557623

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !86

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Can we add a test case, module is lacking in that

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

I won't be able to do that, but I can see that it would be valueable.

smustgrave’s picture

smustgrave commented

I’ll try and find time. This module has been lacking in my attention that’s my fault

smustgrave’s picture

smustgrave commented

Hey sorry mind providing more concrete steps to reproduce? Changing the default language doesn't break anything for me.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

@smustgrave are you using drush secrev after you've changed the default language, or going through the UI?

Over here, this happens on the latest Drupal 10.5.6 with drush secrev on all sites that are configured that way.

smustgrave’s picture

smustgrave commented

I tested with drush secrev

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

ran into this issue fixing another issue and don't know why we would use the title for anything really so I'm merging.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.