Problem/Motivation

Drupal\jsonapi\Normalizer\FieldItemNormalizer->checkForSerializedStrings()() (Line: 32) triggers deprecations on PHP 8.5

Steps to reproduce

Run \Drupal\Tests\jsonapi\Functional\JsonApiRegressionTest::testEmptyMapFieldTypeDenormalization

Proposed resolution

Move the NULL $data optimisation even earlier.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557579

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13824

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

+1

catch’s picture

catch
he/him
Primary language English
commented
Title: Drupal\jsonapi\Normalizer\FieldItemNormalizer->checkForSerializedStrings()() (Line: 32) triggers deprecations on PHP 8.2 » Drupal\jsonapi\Normalizer\FieldItemNormalizer->checkForSerializedStrings()() (Line: 32) triggers deprecations on PHP 8.5
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 5dc271dd on 11.3.x 
    fix: #3557579 Drupal\jsonapi\Normalizer\FieldItemNormalizer->...

  • catch committed ac99525a on 11.x 
    fix: #3557579 Drupal\jsonapi\Normalizer\FieldItemNormalizer->...

catch closed merge request !13824

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.