Problem/Motivation

\Drupal\Tests\rest\Functional\EntityResource\EntityResourceTestBase::setUp() causes deprecations in \Drupal\Core\Entity\ContentEntityStorageBase::getFromPersistentCache() because it tries to reload entities using a NULL ID.

Steps to reproduce

Run \Drupal\Tests\contact\Functional\Rest\MessageXmlBasicAuthTest

Proposed resolution

If the entity has no ID do not reload it.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557531

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13819

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

A bit of polishing and rebase

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed ad6eb723 on 11.3.x 
    fix: #3557531 \Drupal\Tests\rest\Functional\EntityResource\...

catch closed merge request !13819

  • catch committed 25d7a54c on 11.x 
    fix: #3557531 \Drupal\Tests\rest\Functional\EntityResource\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.