Problem/Motivation

\Drupal\content_moderation\ViewsData::getViewsData() causes PHP 8.5 deprecations and tries to and moderation_state info for non-existing table

Steps to reproduce

Run \Drupal\Tests\content_moderation\Kernel\ViewsModerationStateFilterTest::testNonTranslatableEntityType

Proposed resolution

Do not add info for non-existing table.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557467

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13807

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Ran locally on 8.5.0RC03

Got 1 test triggered 1 PHP deprecation:

1) /var/www/html/core/modules/content_moderation/src/ViewsData.php:73
Using null as an array offset is deprecated, use an empty string instead

With the MR got 0

Change LGTM

  • catch committed 00f595f1 on 11.3.x 
    fix: #3557467 \Drupal\content_moderation\ViewsData::getViewsData()...

  • catch committed b61a7381 on 11.x 
    fix: #3557467 \Drupal\content_moderation\ViewsData::getViewsData()...

catch closed merge request !13807

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.